fix routing on windows. #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The-EDev
reviewed
Aug 24, 2021
88f3708 to
823e891
Compare
The-EDev
approved these changes
Aug 24, 2021
Member
The-EDev
left a comment
There was a problem hiding this comment.
Thanks, Will merge once CI is done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like the blueprints feature broke crow on some (at least mine) windows machines.
On my linux instance, executing
pop_backon an empty vector doesn't seem to do anything. On my windows instance though, it crashes the program. This PR just checks if theblueprints-vector is empty and only if it isn't, removes an item.It is undefined behavior to use
pop_backon an empty vector and should be avoided.