Adds SBOM generation using cmake-sbom #1066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I set specific dependency versions in the CMake but I noticed that this breaks macos and windows builds. I will need to fix it |
d47ece4 to
4701813
Compare
Contributor
Author
|
The PR is now ready for review 😄 |
gittiver
reviewed
Aug 7, 2025
gittiver
reviewed
Aug 7, 2025
gittiver
requested changes
Aug 7, 2025
Member
gittiver
left a comment
There was a problem hiding this comment.
I wanted to request to use cpm instead of a git submodule and there seems to be a small typo.
dacef19 to
7e10ab7
Compare
7162de7 to
031eef4
Compare
gittiver
approved these changes
Aug 15, 2025
gittiver
approved these changes
Aug 17, 2025
aumuell
added a commit
to aumuell/Crow
that referenced
this pull request
Aug 22, 2025
This again allows crow to be used as a CMake subproject. This broke in CrowCpp#1066, as CMAKE_SOURCE_DIR refers to the directory of the root CMakeLists.txt. And when being used from a toplevel project, ${CMAKE_SOURCE_DIR}/cmake/CPM.cmake would not refer to crow's copy of CPM. This change makes the reference relative to the location of the CMakeLists.txt requiring the include.
gittiver
pushed a commit
that referenced
this pull request
Aug 24, 2025
This again allows crow to be used as a CMake subproject. This broke in #1066, as CMAKE_SOURCE_DIR refers to the directory of the root CMakeLists.txt. And when being used from a toplevel project, ${CMAKE_SOURCE_DIR}/cmake/CPM.cmake would not refer to crow's copy of CPM. This change makes the reference relative to the location of the CMakeLists.txt requiring the include.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the generation of SBOM as request in #1043.
It adds https://github.com/DEMCON/cmake-sbom as a submodule and uses it to create the SBOM file which contains all the dependencies.
To control whether to generate the SBOM or not, a new compilation flag has been added.