Omit Server header when server_name is empty #1021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to RFC 9110 Section 10.2.4, the Server header field
in responses is optional (MAY be sent).
This change modifies the connection logic to prevent automatically
adding the 'Server' header if the application-wide server_name
is configured to be an empty string via `app.server_name("")`.
Addresses issue CrowCpp#1020
gittiver
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to RFC 9110 Section 10.2.4, the Server header field in responses is optional (MAY be sent).
This change prevents automatically adding the 'Server' header if the application-wide
server_nameis configured to be an empty string viaapp.server_name("").Addresses issue #1020