Repository navigation
Adds Collection.flatMapBatches(of:). - #73
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #73 +/- ##
==========================================
+ Coverage 96.91% 97.01% +0.09%
==========================================
Files 58 60 +2
Lines 3114 3215 +101
==========================================
+ Hits 3018 3119 +101
Misses 96 96
Continue to review full report at Codecov.
|
Collection.batchedSubscribe(by:).
Member
|
Thanks for putting this together! I'm having a hard time with the name though :) Got any other ideas? |
Member
Author
|
How’s |
Member
|
What about |
h/t to @freak4pc and @natecook1000 for this implementation from a thread in iOS Folks. 👏🏽
Member
Author
|
@freak4pc, done and done. ✅ |
freak4pc
reviewed
Mar 6, 2021
Comment on lines
+30
to
+33
| $0 == endIndex ? | ||
| nil : | ||
| index($0, offsetBy: size, limitedBy: endIndex) | ||
| ?? endIndex |
Member
There was a problem hiding this comment.
This is the Apple foundation team voodoo alright! 😂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
h/t @freak4pc and @natecook1000 for this implementation from a thread in iOS Folks. 👏🏽