Skip to content

Conversation

@JesusTheHun
Copy link
Contributor

@JesusTheHun JesusTheHun commented Nov 25, 2022

This main purpose of this PR is to close #9 by adding two methods :

grabEntryFromDatabase($table, $criteria); // Fetch the first matching row
grabEntriesFromDatabase($table, $criteria); // Fetch all matching rows

I've joined some tests to cover their respective behaviour.

Also, I made two small changes :

  1. Changed the test of the existence of a key that triggered a warning, making tests fails. The logic has not been changed.
  2. Changed the call of loadDump() to pass the configuration, otherwise it would use the mysql.sock, which is not present when using a remote database (i.e: container).

If this PR goes through, I will port the modification to the branch 3.x.

Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JesusTheHun
Copy link
Contributor Author

@Naktibalda Thanks for your feedback. I've updated the branch according to your suggestions.

@JesusTheHun
Copy link
Contributor Author

@Naktibalda Have you had a chance to review my work ?

@Naktibalda
Copy link
Member

Sorry, I added these comments few days ago and forgot to submit them :)

@JesusTheHun
Copy link
Contributor Author

I've resolved the points you brought up. Are you ready to merge & release ?

@Naktibalda Naktibalda merged commit 32afb4b into Codeception:2.x Dec 3, 2022
@Naktibalda
Copy link
Member

Released as 2.1.0 and 3.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants