-
Notifications
You must be signed in to change notification settings - Fork 30
feat: mysql helper to grab entire rows #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: mysql helper to grab entire rows #43
Conversation
Arhell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @Naktibalda
|
@Naktibalda Thanks for your feedback. I've updated the branch according to your suggestions. |
|
@Naktibalda Have you had a chance to review my work ? |
|
Sorry, I added these comments few days ago and forgot to submit them :) |
|
I've resolved the points you brought up. Are you ready to merge & release ? |
This main purpose of this PR is to close #9 by adding two methods :
I've joined some tests to cover their respective behaviour.
Also, I made two small changes :
loadDump()to pass the configuration, otherwise it would use themysql.sock, which is not present when using a remote database (i.e: container).If this PR goes through, I will port the modification to the branch
3.x.