Add fdatasync declaration on darwin#496
Merged
chrissie-c merged 2 commits intoClusterLabs:mainfrom Aug 28, 2024
Merged
Conversation
|
Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/libqb/job/libqb-pipeline/job/PR-496/1/input |
13 tasks
|
Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/libqb/job/libqb-pipeline/job/PR-496/2/input |
Contributor
|
retest this pleae |
Contributor
|
retest this please |
chrissie-c
approved these changes
Aug 28, 2024
Contributor
chrissie-c
left a comment
There was a problem hiding this comment.
Looks OK to me, sorry for the delay
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clang 16 starts to explicitly fail on undeclared functions. Unfortunately, while darwin provides the implementation, it's not available in any header.
This can be hacked around by providing a custom signature in the config header. There may be a less terrible way to achieve it.