Fix Unknown setting profile error on attempt to set settings profile
#18167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexey-milovidov
approved these changes
Dec 16, 2020
This was referenced Dec 17, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Dec 17, 2020
…mpt to set settings profile
robot-clickhouse
pushed a commit
that referenced
this pull request
Dec 17, 2020
…mpt to set settings profile
robot-clickhouse
pushed a commit
that referenced
this pull request
Dec 17, 2020
…mpt to set settings profile
robot-clickhouse
pushed a commit
that referenced
this pull request
Dec 17, 2020
…pt to set settings profile
vitlibar
reviewed
Dec 17, 2020
|
|
||
| if (setting_name == "profile") | ||
| { | ||
| /// TODO Check profile settings in Context::setProfile(...), not here. It will be backward incompatible. |
Member
There was a problem hiding this comment.
I agree with this TODO, I think I'll make some refactoring later.
tavplubix
added a commit
that referenced
this pull request
Dec 17, 2020
Backport #18167 to 20.11: Fix `Unknown setting profile` error on attempt to set settings profile
tavplubix
added a commit
that referenced
this pull request
Dec 17, 2020
Backport #18167 to 20.12: Fix `Unknown setting profile` error on attempt to set settings profile
tavplubix
added a commit
that referenced
this pull request
Dec 17, 2020
Backport #18167 to 20.10: Fix `Unknown setting profile` error on attempt to set settings profile
tavplubix
pushed a commit
that referenced
this pull request
Dec 17, 2020
…gs_constraints Fix `Unknown setting profile` error on attempt to set settings profile (cherry picked from commit 81c00a4)
alexey-milovidov
added a commit
that referenced
this pull request
Dec 31, 2020
Better version of #18167
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix
Unknown setting profileerror on attempt to set settings profile.