Add .venv to skip patterns#1483
Merged
vhvb1989 merged 5 commits intoAzure:mainfrom Feb 3, 2023
pamelafox:skip-venv
Merged
Conversation
vhvb1989
approved these changes
Feb 3, 2023
Member
|
this should unblock you for now. |
Member
Author
|
Thanks @vhvb1989 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related:
#1039
#1237
I'm trying to port one of the official function samples to azd, but the current sample assumes that there's a ".venv" folder for a Python virtual environment, and it would be a large code change to the sample to remove that assumption. (And potentially to the functions extension as well, as it's baked into the auto-generated files).
So, until there's a longer term solution, I was hoping we could just manually skip .venv for now. That's the most common name for the directory (as it's spelled that way in Python docs) and the name in the function sample/template as well.
What do you think?