Overwrite unversioned azd.exe on install#1424
Conversation
|
/cc @timheuer |
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash: pwsh: WindowsPowerShell install MSI install Standalone Binary
MSIContainerDocumentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference (preview)
|
|
@heaths -- I tested locally and demonstrated the fix does work in the scenario we uncovered. What are the long-term disadvantages of this approach? I want to make sure we're making the right tradeoffs here. |
|
It'll overwrite whatever is there regardless of how it was installed. As long as they keep using the MSIs, at least the MSIs will only overwrite older installed products, but versioned files are best. As mentioned in Teams, it's long been best practice to use versioned files as key paths - even the point of bundling a bunch of unversioned files into the same component with a versioned key path in Windows Installer because versions make better comparators. |
danieljurek
left a comment
There was a problem hiding this comment.
Thanks again, Heath!
In the future when we get azd.exe versioning properly we can remove REINSTALLMODE.
I'd wait for after a few releases, though. Off hand, I don't remember how Windows Installer will treat a versioned file over an unversioned file. Given the choice is based on what's present on disk, off hand I'd assume a seemingly "modified" (modified > created) unversioned file won't be replaced by a versioned file. |
Fixes #1406