Adding apiManagementConfig to connect function/web apps#1403
Adding apiManagementConfig to connect function/web apps#1403weikanglim merged 11 commits intoAzure:mainfrom pamelafox:apim-config
Conversation
|
Update: I've tested with a function app with and without useApim and also tested an ACA app with and without useApim (where I would expect the setting to get ignored). Things looks good. |
|
LGTM, @rajeshkamal5050 do we want to run automation or manual tests on this? |
|
@pamelafox you can run the template tests automation pipeline with/without APIM. It should cover for any regressions. @weikanglim please add if any additional testing needs to be done. |
|
@rajeshkamal5050 Thanks, I'm trying to figure out how to trigger that pipeline for my branch, I haven't used ADO pipelines before and am wondering if I'm lacking permissions or just don't know what to click. Here's what I see:
I thought I'd find a manual trigger option in the branches tab, but don't see anything there or in the menu on it. Can you advise? |
|
/azp run azure-dev - template - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hm, the "install azd" task failed on that job. The output shows it trying to download from a different URL than previous jobs. |
|
@danieljurek @weikanglim can you help in running the template test pipelines with/without APIM? |
|
/azp run azure-dev - repoman |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
We've got two pipeline runs verifying this:
|
|
/azp run azure-dev - repoman |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Running with APIM enabled: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=2152232&view=results Going to quickly verify this before merging. |
wbreza
left a comment
There was a problem hiding this comment.
LGTM - added one suggestion around dependsOn usage.
|
/azp run azure-dev - repoman |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@wbreza Not sure why I had the dependsOn originally, I sometimes put it to be better "safe than sorry" or while working around Bicep issues. However, I just tried removing it from todo-python and it seemed to deploy fine. Hopefully the template tests all pass! Thanks for the help. |
|
/azp run azure-dev - repoman |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Repoman Generation ResultsRepoman pushed changes to remotes for the following projects: Project: todo-csharp-cosmos-sqlRemote: azure-samples-stagingBranch: pr/1403You can initialize this project with: azd init -t Azure-Samples/todo-csharp-cosmos-sql -b pr/1403View Changes | Compare Changes Project: todo-csharp-sql-swa-funcRemote: azure-samples-stagingBranch: pr/1403You can initialize this project with: azd init -t Azure-Samples/todo-csharp-sql-swa-func -b pr/1403View Changes | Compare Changes Project: todo-csharp-sqlRemote: azure-samples-stagingBranch: pr/1403You can initialize this project with: azd init -t Azure-Samples/todo-csharp-sql -b pr/1403View Changes | Compare Changes Project: todo-java-mongo-acaRemote: azure-samples-stagingBranch: pr/1403You can initialize this project with: azd init -t Azure-Samples/todo-java-mongo-aca -b pr/1403View Changes | Compare Changes Project: todo-java-mongoRemote: azure-samples-stagingBranch: pr/1403You can initialize this project with: azd init -t Azure-Samples/todo-java-mongo -b pr/1403View Changes | Compare Changes Project: todo-nodejs-mongo-acaRemote: azure-samples-stagingBranch: pr/1403You can initialize this project with: azd init -t Azure-Samples/todo-nodejs-mongo-aca -b pr/1403View Changes | Compare Changes Project: todo-nodejs-mongo-swa-funcRemote: azure-samples-stagingBranch: pr/1403You can initialize this project with: azd init -t Azure-Samples/todo-nodejs-mongo-swa-func -b pr/1403View Changes | Compare Changes Project: todo-nodejs-mongoRemote: azure-samples-stagingBranch: pr/1403You can initialize this project with: azd init -t Azure-Samples/todo-nodejs-mongo -b pr/1403View Changes | Compare Changes Project: todo-python-mongo-acaRemote: azure-samples-stagingBranch: pr/1403You can initialize this project with: azd init -t Azure-Samples/todo-python-mongo-aca -b pr/1403View Changes | Compare Changes Project: todo-python-mongo-swa-funcRemote: azure-samples-stagingBranch: pr/1403You can initialize this project with: azd init -t Azure-Samples/todo-python-mongo-swa-func -b pr/1403View Changes | Compare Changes Project: todo-python-mongoRemote: azure-samples-stagingBranch: pr/1403You can initialize this project with: azd init -t Azure-Samples/todo-python-mongo -b pr/1403View Changes | Compare Changes |
Web Apps and Functions both have an "API Management" link in the left sidebar in Azure Portal that can optionally embed a connected API Management instance.
That link is set by the apiManagementConfig property on the Web/Function app.
This PR adds that configuration to all the samples with a Web/Function App backend. The samples that use Azure Container Apps should not be affected by the change.
I have verified this works on todo-python-mongo-swa-func and will test a few others as well. I am hoping there's an automated build for all the TODO apps once I make a pull request, but that may be wishful thinking. I'll find out soon!