Skip to content
This repository was archived by the owner on Oct 24, 2023. It is now read-only.

feat: EncryptionAtHost support#3041

Merged
jackfrancis merged 1 commit intoAzure:masterfrom
andyzhangx:encryption-at-host
Apr 9, 2020
Merged

feat: EncryptionAtHost support#3041
jackfrancis merged 1 commit intoAzure:masterfrom
andyzhangx:encryption-at-host

Conversation

@andyzhangx
Copy link
Copy Markdown
Contributor

@andyzhangx andyzhangx commented Apr 8, 2020

Reason for Change:

This PR is actually a place holder, it's mainly for AKS to support EncryptionAtHost(Enable Encryption at Host support for VM/VMSS) (JEDI requirement) which is going to be in private preview late this month.

EncryptionAtHost functionality actually does not work by this PR since it depends on

  • go sdk ready and upgrade to supported go sdk version
  • EncryptionAtHost feature on public regions ready
  • subs whitelist

Will make it work when the above 3 requirements are fullfilled.

Issue Fixed:

Requirements:

Notes:

@andyzhangx andyzhangx requested a review from jackfrancis April 8, 2020 09:20
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2020

Codecov Report

Merging #3041 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3041   +/-   ##
=======================================
  Coverage   70.58%   70.59%           
=======================================
  Files         145      145           
  Lines       25105    25109    +4     
=======================================
+ Hits        17721    17725    +4     
  Misses       6281     6281           
  Partials     1103     1103           
Impacted Files Coverage Δ
pkg/api/types.go 94.05% <ø> (ø)
pkg/api/vlabs/types.go 74.31% <ø> (ø)
pkg/api/converterfromapi.go 93.82% <100.00%> (+0.02%) ⬆️
pkg/api/convertertoapi.go 93.63% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96e1a16...db1e918. Read the comment docs.

@andyzhangx
Copy link
Copy Markdown
Contributor Author

/azp run pr-e2e

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@jackfrancis
Copy link
Copy Markdown
Member

Thanks @andyzhangx, I've put a hold label on the PR. Let us know when we can consider reviewing/merging the PR.

@xuto2
Copy link
Copy Markdown
Contributor

xuto2 commented Apr 8, 2020

/lgtm

Copy link
Copy Markdown
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants