types(document): add id virtual getter by default to HydrateDocument<> if TOverrides is Record<string, never>
#15906
+45
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #15900
Summary
An unintentional backwards breaking change in Mongoose 9 when we removed
idas a property onDocument: people who usenew Schema<RawDocType>()no longer get theidvirtual by default. Works fine with automatic inferencenew Schema(), but once you override RawDocType theidvirtual goes away.This PR adds the
idvirtual ifTOverridesisRecord<string, never>, which is the default. Unlessid: falseoption is set, or the RawDocType has anidproperty.Examples