Repository navigation
[OSRS] Fix UT integraiton and various gen failures - #5331
Merged
Exempt-Medic merged 4 commits intoAug 16, 2025
Merged
Conversation
…tion using the new UT fuzzer integration
digiholic
approved these changes
Aug 15, 2025
digiholic
left a comment
Collaborator
There was a problem hiding this comment.
All looks good to me, most of it was run by me in the discord already. No surprises.
benny-dreamly
approved these changes
Aug 15, 2025
benny-dreamly
left a comment
Contributor
There was a problem hiding this comment.
lgtm, code looks fine (did not manage to test the UT part of the PR)
Exempt-Medic
suggested changes
Aug 15, 2025
Exempt-Medic
left a comment
Contributor
There was a problem hiding this comment.
A few comments from a brief initial look
Exempt-Medic
approved these changes
Aug 16, 2025
eternalcode0
pushed a commit
to eternalcode0/Archipelago
that referenced
this pull request
Dec 20, 2025
eternalcode0
pushed a commit
to eternalcode0/Archipelago
that referenced
this pull request
Dec 21, 2025
wcoldren
pushed a commit
to wcoldren/Archipelago
that referenced
this pull request
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
the OSRS UT integration had some limits when task categories weren't set to maximum possible tasks,
In fixing this, some gen failures were identified and fixed/added OptionError exceptions where relevant
Also fixes problem with get_filler_item_name
How was this tested?
Tested using the new UT fuzzer integration
If this makes graphical changes, please attach screenshots.