Skip to content

Conversation

@mdo
Copy link
Member

@mdo mdo commented May 8, 2021

No description provided.

@XhmikosR XhmikosR added docs and removed meta labels May 11, 2021
ga('send', 'pageview');
</script>
<script async src="https://www.google-analytics.com/analytics.js"></script>
<script defer src="https://cdn.usefathom.com/script.js" data-site="TAXRUMOF"></script>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any specific reason this is defer and not async?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's what they included in their code snippet. We can try to switch it around.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdo we should drop GA, shouldn't we?

@mdo
Copy link
Member Author

mdo commented May 13, 2021

Shipping as-is for now—will revisit for v5.1.0.

@mdo mdo merged commit 3464d3c into main May 13, 2021
@mdo mdo deleted the v5-fathom branch May 13, 2021 04:34
XhmikosR pushed a commit that referenced this pull request May 14, 2021
* Add Fathom Analytics to v5 docs

* newline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants