Skip to content

Conversation

@jrn2778
Copy link
Contributor

@jrn2778 jrn2778 commented May 6, 2021

Fixes #33847

I made all the changes suggested for the "Border hero with cropped image and shadows".

I did not make the change for the centered hero because I could not verify that it would produce the exact same result as prior to the change. Was hoping someone else could double check that again and I could make adjustments as needed.

@mdo
Copy link
Member

mdo commented May 6, 2021

I did not make the change for the centered hero because I could not verify that it would produce the exact same result as prior to the change. Was hoping someone else could double check that again and I could make adjustments as needed.

Confirmed it—go ahead and make the change in this PR if you don't mind :).

@mdo mdo added the examples label May 6, 2021
@jrn2778
Copy link
Contributor Author

jrn2778 commented May 6, 2021

@mdo Thank you for the input! I made both changes :)

@mdo mdo merged commit eb73a2f into twbs:main May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Possible mistakes at https://getbootstrap.com/docs/5.0/examples/heroes/

2 participants