Lazy dependency proxy does not populate bean dependencies

[BoykoAlex]

Start off with the latest spring-petclinic project based on Boot 2.3.x
Launch the app and see the JSON response for /actuator/beans
Search for OwnerController bean. This bean should depend on OwnerRepository and PetRepository. The JSON for the bean however is this:

        "ownerController": {
          "aliases": [],
          "scope": "singleton",
          "type": "org.springframework.samples.petclinic.owner.OwnerController",
          "resource": "file [/Users/aboyko/Documents/runtime-sts4/spring-petclinic/target/classes/org/springframework/samples/petclinic/owner/OwnerController.class]",
          "dependencies": []
        },

If spring-petclinic is switched to Boot 2.2.x then the dependencies are detected correctly:

        "ownerController": {
          "aliases": [],
          "scope": "singleton",
          "type": "org.springframework.samples.petclinic.owner.OwnerController",
          "resource": "file [/Users/aboyko/Documents/runtime-sts4/spring-petclinic/target/classes/org/springframework/samples/petclinic/owner/OwnerController.class]",
          "dependencies": [
            "ownerRepository",
            "visitRepository"
          ]
        },

Something is off in the framework as actuator simply calls org.springframework.beans.factory.config.ConfigurableBeanFactory.getDependenciesForBean(String)

Try this in the org.springframework.samples.petclinic.PetClinicApplication for the main method:

	public static void main(String[] args) {
		ConfigurableApplicationContext context = SpringApplication.run(PetClinicApplication.class, args);

		final ScheduledExecutorService scheduler = Executors.newScheduledThreadPool(1);

		final Runnable printDependnecies = new Runnable() {
			public void run() {
				String[] dependenciesForBean = context.getBeanFactory().getDependenciesForBean("ownerController");
				
				if (dependenciesForBean.length == 0) {
					System.out.println("no dependencies!!!");
				} else {
					System.out.println("Dependencies:");
					for (String dep : dependenciesForBean) {
						System.out.println(dep);
					}
					System.out.println();
				}
			}
		};

		scheduler.scheduleAtFixedRate(printDependnecies, 10, 10, TimeUnit.SECONDS);

	}

You'd see that there are no dependencies returned in the Boot 2.3.x case.

[snicoll]

Spring Boot 2.3 uses the same Spring Framework generation as Spring Boot 2.2. If you've debugged this, it would be nice to share the two Spring Framework versions that you've used.

[BoykoAlex]

Yes, it seems to be Spring 5.2.8.RELEASE in both cases. Should this be routed to Boot then?

[snicoll]

Thank you. I've reproduced the problem and it does not occur with Spring Boot 2.2.9.RELEASE indeed.

[snicoll]

It's interesting to see that the bean dependencies aren't available in the core BeanRegistry so I don't immediately see why it works with Spring Boot 2.2.9.RELEASE but does not with 2.3.2.RELEASE, given the same framework version is used.

[wilkinsona]

I think this is a Framework bug. The change in behaviour is due to the JPA repositories being lazy by default in Spring Boot 2.3. The repository dependencies are detected again if you set spring.data.jpa.repositories.bootstrap-mode=default. They're missing in the lazy case due to this logic in DefaultListableBeanFactory:

Object result = getAutowireCandidateResolver().getLazyResolutionProxyIfNecessary(
		descriptor, requestingBeanName);
if (result == null) {
	result = doResolveDependency(descriptor, requestingBeanName, autowiredBeanNames, typeConverter);
}
return result;

In the lazy case, result is non-null so autowiredBeanNames is never populated.

[snicoll]

Very nice detective work @wilkinsona!

@BoykoAlex you can workaround the problem in the meantime adding the following to application.properties:

spring.data.jpa.repositories.bootstrap-mode=default

[snicoll]

@jhoeller I've tentatively assigned 5.2.9.