Conversation
src/v1/function-builder.ts
Outdated
| * Value must not be null. | ||
| */ | ||
| export function runWith(runtimeOptions: RuntimeOptions): FunctionBuilder { | ||
| export function runWith(runtimeOptions: DeploymentOptions): FunctionBuilder { |
There was a problem hiding this comment.
hmm this would mean things like region would also be suggested in runWith which shouldn't be.
I wonder I made the mistake of setting preserveExternalChanges Deployment Option instead of Runtime Option. It doesn't sound right that preserveExternalChanges is a runtime option, but then that's the only way I can abuse runWith tag 😢
There was a problem hiding this comment.
Hmm yeah I figured this was a bug since I couldn't figure out a way to use preserveExternalChanges without making this change. Also, the v1 docs show preserveExternalChanges in the runtime options section - https://firebase.google.com/docs/functions/manage-functions#set_runtime_options
Should we just dump preserveExternalChanges into RuntimeOptions instead? That way we wouldn't have to fix any docs, but might not be the cleanest looking...
There was a problem hiding this comment.
let's dump it in RuntimeOptions. I think runWith is already a dumping of options.
taeold
left a comment
There was a problem hiding this comment.
lgtm - would consider moving the preserveExternalChanges option to runtime options instead.
Uh oh!
There was an error while loading. Please reload this page.