Clarify comment on multixid offset wraparound check

Coverity complained that offset cannot be 0 here because there's an
explicit check for "offset == 0" earlier in the function, but it
didn't see the possibility that offset could've wrapped around to 0.
The code is correct, but clarify the comment about it.

The same code exists in backbranches in the server
GetMultiXactIdMembers() function and in 'master' in the pg_upgrade
GetOldMultiXactIdSingleMember function. In backbranches Coverity
didn't complain about it because the check was merely an assertion,
but change the comment in all supported branches for consistency.

Per Tom Lane's suggestion.

Discussion: https://www.postgresql.org/message-id/1827755.1765752936@sss.pgh.pa.us

diff --git a/src/backend/access/transam/multixact.c b/src/backend/access/transam/multixact.c
index e80e4b198e127e1e9d5d8e9b77dce1db3f9c4119..dd02d54fc50b4064170e2e0d48e4e79d404add4e 100644 (file)
--- a/src/backend/access/transam/multixact.c
+++ b/src/backend/access/transam/multixact.c
@@ -1503,7 +1503,10 @@ GetMultiXactIdMembers(MultiXactId multi, MultiXactMember **members,
 
        if (!TransactionIdIsValid(*xactptr))
        {
-           /* Corner case 2: we must be looking at unused slot zero */
+           /*
+            * Corner case 2: offset must have wrapped around to unused slot
+            * zero.
+            */
            Assert(offset == 0);
            continue;
        }