Fix race in SSI interaction with gin fast path.
authorThomas Munro <[email protected]>
Mon, 3 Jul 2023 04:20:01 +0000 (16:20 +1200)
committerThomas Munro <[email protected]>
Mon, 3 Jul 2023 21:21:33 +0000 (09:21 +1200)
commit255a925d333be9a3d6314e2fe698063eb8e753a6
treed5e78762bf34f307e7e5d52b15666a368e23c2e3
parent17b8887c29e55e2ac2e04a41a87714a4960484fa
Fix race in SSI interaction with gin fast path.

The ginfast.c code previously checked for conflicts in before locking
the relevant buffer, leaving a window where a RW conflict could be
missed.  Re-order.

There was also a place where buffer ID and block number were confused
while trying to predicate-lock a page, noted by visual inspection.

Back-patch to all supported releases.  Fixes one more problem discovered
with the reproducer from bug #17949, in this case when Dmitry tried
other index types.

Reported-by: Artem Anisimov <[email protected]>
Reported-by: Dmitry Dolgov <[email protected]>
Reviewed-by: Heikki Linnakangas <[email protected]>
Discussion: https://postgr.es/m/17949-a0f17035294a55e2%40postgresql.org
src/backend/access/gin/ginfast.c
src/backend/access/gin/ginget.c