From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Fri, 15 Sep 2017 04:25:33 +0000 (-0400)
Subject: Avoid duplicate typedef for SharedRecordTypmodRegistry.
X-Git-Tag: jit-before-rebase-2017-11-03~257
X-Git-Url: http://git.postgresql.org/gitweb/static/gitweb.js?a=commitdiff_plain;h=fba366555659fc1dc66a825196be3cc68640d289;p=users%2Fandresfreund%2Fpostgres.git

Avoid duplicate typedef for SharedRecordTypmodRegistry.

This isn't our usual solution for such problems, and older compilers
(not terribly old, either) don't like it.

Per buildfarm and local testing.
---

diff --git a/src/include/access/session.h b/src/include/access/session.h
index 8376dc5312..45986208c8 100644
--- a/src/include/access/session.h
+++ b/src/include/access/session.h
@@ -14,8 +14,8 @@
 
 #include "lib/dshash.h"
 
-/* Defined in typcache.c */
-typedef struct SharedRecordTypmodRegistry SharedRecordTypmodRegistry;
+/* Avoid including typcache.h */
+struct SharedRecordTypmodRegistry;
 
 /*
  * A struct encapsulating some elements of a user's session.  For now this
@@ -28,7 +28,7 @@ typedef struct Session
 	dsa_area   *area;			/* The session-scoped DSA area. */
 
 	/* State managed by typcache.c. */
-	SharedRecordTypmodRegistry *shared_typmod_registry;
+	struct SharedRecordTypmodRegistry *shared_typmod_registry;
 	dshash_table *shared_record_table;
 	dshash_table *shared_typmod_table;
 } Session;