From: Peter Eisentraut <peter@eisentraut.org>
Date: Wed, 4 Dec 2024 15:43:07 +0000 (+0100)
Subject: Fix dead code
X-Git-Url: http://git.postgresql.org/gitweb/static/gitweb.js?a=commitdiff_plain;h=dfbb092cff70ee4d4084b7e4e57228a89ff4f9f8;p=users%2Fc2main%2Fpostgres.git

Fix dead code

from commit 85b7efa1cdd

per Coverity report
---

diff --git a/src/backend/utils/adt/like_match.c b/src/backend/utils/adt/like_match.c
index afe5406cf4..f19692c3ca 100644
--- a/src/backend/utils/adt/like_match.c
+++ b/src/backend/utils/adt/like_match.c
@@ -333,13 +333,14 @@ MatchText(const char *t, int tlen, const char *p, int plen, pg_locale_t locale)
 				 * fails.  Otherwise, try again with a longer substring.
 				 */
 				if (t1len == 0)
+				{
+					if (buf)
+						pfree(buf);
 					return LIKE_FALSE;
+				}
 				else
 					NextChar(t1, t1len);
 			}
-			if (buf)
-				pfree(buf);
-			continue;
 		}
 		else if (GETCHAR(*p, locale) != GETCHAR(*t, locale))
 		{