From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Thu, 30 Dec 2004 00:30:40 +0000 (+0000)
Subject: Triggers should return TRIGGER not OPAQUE.  Looks like this script got
X-Git-Url: http://git.postgresql.org/gitweb/static/gitweb.js?a=commitdiff_plain;h=d9ed22510aa1777c39d26584daf70dad566a1ded;p=users%2Fbernd%2Fpostgres.git

Triggers should return TRIGGER not OPAQUE.  Looks like this script got
overlooked in 7.3 updates.  Not a critical fix but avoids a notice when
the resulting SQL script is executed.
---

diff --git a/contrib/oracle/Ora2Pg.pm b/contrib/oracle/Ora2Pg.pm
index fd6656f8b8..0fbecba007 100644
--- a/contrib/oracle/Ora2Pg.pm
+++ b/contrib/oracle/Ora2Pg.pm
@@ -881,7 +881,7 @@ print STDERR "Add triggers definition...\n" if ($self->{debug});
 				if ($self->{export_schema}) {
 					$sql_output .= "SET search_path = $self->{schema}, pg_catalog;\n\n";
 				}
-				$sql_output .= "CREATE FUNCTION pg_fct_\L$trig->[0]\E () RETURNS OPAQUE AS '\n$trig->[4]\n' LANGUAGE 'plpgsql'\n\n";
+				$sql_output .= "CREATE FUNCTION pg_fct_\L$trig->[0]\E () RETURNS TRIGGER AS '\n$trig->[4]\n' LANGUAGE 'plpgsql'\n\n";
 				$sql_output .= "CREATE TRIGGER \L$trig->[0]\E\n\t$trig->[1] $trig->[2] ON \"\L$trig->[3]\E\" FOR EACH ROW\n\tEXECUTE PROCEDURE pg_fct_\L$trig->[0]\E();\n\n";
 			}
 		}