From: Heikki Linnakangas Date: Wed, 12 Nov 2025 19:19:03 +0000 (+0200) Subject: Clear 'xid' in dummy async notify entries written to fill up pages X-Git-Url: http://git.postgresql.org/gitweb/static/gitweb.js?a=commitdiff_plain;h=d80d5f09950281c6b852f8d121955bfa182ae539;p=postgresql.git Clear 'xid' in dummy async notify entries written to fill up pages Before we started to freeze async notify entries (commit 8eeb4a0f7c), no one looked at the 'xid' on an entry with invalid 'dboid'. But now we might actually need to freeze it later. Initialize them with InvalidTransactionId to begin with, to avoid that work later. Álvaro pointed this out in review of commit 8eeb4a0f7c, but I forgot to include this change there. Author: Álvaro Herrera Discussion: https://www.postgresql.org/message-id/202511071410.52ll56eyixx7@alvherre.pgsql Backpatch-through: 14 --- diff --git a/src/backend/commands/async.c b/src/backend/commands/async.c index e94d5c4a668..b788ac45e17 100644 --- a/src/backend/commands/async.c +++ b/src/backend/commands/async.c @@ -1418,6 +1418,7 @@ asyncQueueAddEntries(ListCell *nextNotify) */ qe.length = QUEUE_PAGESIZE - offset; qe.dboid = InvalidOid; + qe.xid = InvalidTransactionId; qe.data[0] = '\0'; /* empty channel */ qe.data[1] = '\0'; /* empty payload */ }