From: Tomas Vondra <tomas@2ndquadrant.com>
Date: Fri, 20 Jan 2017 01:34:39 +0000 (+0100)
Subject: comment about a place adding unnecessary top-level RemoteSubpans
X-Git-Tag: XL_10_R1BETA1~435
X-Git-Url: http://git.postgresql.org/gitweb/static/gitweb.js?a=commitdiff_plain;h=bce1e89f877397e3e298f21e4a3f33fed116b3dd;p=postgres-xl.git

comment about a place adding unnecessary top-level RemoteSubpans
---

diff --git a/src/backend/optimizer/plan/planner.c b/src/backend/optimizer/plan/planner.c
index 1bb2bcb1ce..4cab3aea93 100644
--- a/src/backend/optimizer/plan/planner.c
+++ b/src/backend/optimizer/plan/planner.c
@@ -330,6 +330,11 @@ standard_planner(Query *parse, int cursorOptions, ParamListInfo boundParams)
 #ifdef XCP
 	if (root->distribution)
 	{
+		/*
+		 * FIXME, this keeps adding RemoteSubplan at a top of queries that
+		 * don't really need it (e.g above a MergeAppend with subplans pushed
+		 * to remote nodes). Not sure why it's happening, though ...
+		 */
 		top_plan = (Plan *) make_remotesubplan(root, top_plan, NULL,
 											   root->distribution,
 											   root->query_pathkeys);