From: Andrew Dunstan <andrew@dunslane.net>
Date: Sat, 25 Jul 2009 13:35:32 +0000 (+0000)
Subject: Small stylistic improvement in recent FORCE QUOTE * code - use a bool instead of... 
X-Git-Url: http://git.postgresql.org/gitweb/static/gitweb.js?a=commitdiff_plain;h=b197237b7943561f9ac8d99f7a6a2d51bf22e24b;p=users%2Fsimon%2Fpostgres.git

Small stylistic improvement in recent FORCE QUOTE * code - use a bool instead of a magic value.
---

diff --git a/src/backend/commands/copy.c b/src/backend/commands/copy.c
index 9ee8ea2c82..f74eb35937 100644
--- a/src/backend/commands/copy.c
+++ b/src/backend/commands/copy.c
@@ -729,9 +729,7 @@ DoCopy(const CopyStmt *stmt, const char *queryString)
 	TupleDesc	tupDesc;
 	int			num_phys_attrs;
 	uint64		processed;
-
-	/* a dummy list that represents 'all-columns' */
-	List		all_columns = { T_List };
+	bool		force_quote_all = false;
 	
 	/* Allocate workspace and zero all fields */
 	cstate = (CopyStateData *) palloc0(sizeof(CopyStateData));
@@ -813,7 +811,7 @@ DoCopy(const CopyStmt *stmt, const char *queryString)
 						 errmsg("conflicting or redundant options")));
 
 			if (IsA(defel->arg, A_Star))
-				force_quote = &all_columns;
+				force_quote_all = true;
 			else
 				force_quote = (List *) defel->arg;
 		}
@@ -1099,7 +1097,7 @@ DoCopy(const CopyStmt *stmt, const char *queryString)
 
 	/* Convert FORCE QUOTE name list to per-column flags, check validity */
 	cstate->force_quote_flags = (bool *) palloc0(num_phys_attrs * sizeof(bool));
-	if (force_quote == &all_columns)
+	if (force_quote_all)
 	{
 		int		i;