From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Wed, 12 Oct 2005 17:18:31 +0000 (+0000)
Subject: Fix longstanding bug found by Atsushi Ogawa: _bt_check_unique would mark
X-Git-Url: http://git.postgresql.org/gitweb/static/gitweb.js?a=commitdiff_plain;h=b122a6869dd9c51abce07853da1ad38a27c0e484;p=users%2Fbernd%2Fpostgres.git

Fix longstanding bug found by Atsushi Ogawa: _bt_check_unique would mark
the wrong buffer dirty when trying to kill a dead index entry that's on
a page after the one it started on.  No risk of data corruption, just
inefficiency, but still a bug.
---

diff --git a/src/backend/access/nbtree/nbtinsert.c b/src/backend/access/nbtree/nbtinsert.c
index f85200328e..184be5765f 100644
--- a/src/backend/access/nbtree/nbtinsert.c
+++ b/src/backend/access/nbtree/nbtinsert.c
@@ -270,7 +270,10 @@ _bt_check_unique(Relation rel, BTItem btitem, Relation heapRel,
 						HEAPTUPLE_DEAD)
 					{
 						curitemid->lp_flags |= LP_DELETE;
-						SetBufferCommitInfoNeedsSave(buf);
+						if (nbuf != InvalidBuffer)
+							SetBufferCommitInfoNeedsSave(nbuf);
+						else
+							SetBufferCommitInfoNeedsSave(buf);
 					}
 					if (sv_infomask != htup.t_data->t_infomask)
 						SetBufferCommitInfoNeedsSave(hbuffer);