From: Magnus Hagander <magnus@hagander.net>
Date: Thu, 30 Oct 2008 17:04:11 +0000 (+0000)
Subject: Revert previous patch to put the shared memory segment on win32
X-Git-Tag: recoveryinfrav9~453
X-Git-Url: http://git.postgresql.org/gitweb/static/gitweb.js?a=commitdiff_plain;h=696df5a57d29781d4433f8cc5ef1bfb7b9a07154;p=users%2Fsimon%2Fpostgres.git

Revert previous patch to put the shared memory segment on win32
in the Global\ namespace, because it caused permission errors on
a lot of platforms.

We need to come up with something better for 8.4, but for now
revert to the pre-8.3.4 behaviour.
---

diff --git a/src/backend/port/win32_shmem.c b/src/backend/port/win32_shmem.c
index 970b552043..893ca609ef 100644
--- a/src/backend/port/win32_shmem.c
+++ b/src/backend/port/win32_shmem.c
@@ -57,7 +57,13 @@ GetSharedMemName(void)
 		elog(FATAL, "could not generate full pathname for datadir %s: %lu",
 			 DataDir, GetLastError());
 
-	for (cp = retptr + 18; *cp; cp++)
+	/* 
+	 * XXX: Intentionally overwriting the Global\ part here. This was not the
+	 * original approach, but putting it in the actual Global\ namespace
+	 * causes permission errors in a lot of cases, so we leave it in
+	 * the default namespace for now.
+	 */
+	for (cp = retptr; *cp; cp++)
 		if (*cp == '\\')
 			*cp = '/';