From: Tom Lane Date: Thu, 23 Apr 2009 17:39:21 +0000 (+0000) Subject: Don't use the result of strcmp as if it were a boolean. X-Git-Url: http://git.postgresql.org/gitweb/static/gitweb.js?a=commitdiff_plain;h=63bebf3c50ea2c07281f6bafcdc19a568be4880f;p=users%2Fsimon%2Fpostgres.git Don't use the result of strcmp as if it were a boolean. A service of your local coding style police. --- diff --git a/src/backend/commands/dbcommands.c b/src/backend/commands/dbcommands.c index a401ae4fa1..d300e57160 100644 --- a/src/backend/commands/dbcommands.c +++ b/src/backend/commands/dbcommands.c @@ -387,12 +387,12 @@ createdb(const CreatedbStmt *stmt) */ if (strcmp(dbtemplate, "template0") != 0) { - if (strcmp(dbcollate, src_collate)) + if (strcmp(dbcollate, src_collate) != 0) ereport(ERROR, (errmsg("new collation is incompatible with the collation of the template database (%s)", src_collate), errhint("Use the same collation as in the template database, or use template0 as template."))); - if (strcmp(dbctype, src_ctype)) + if (strcmp(dbctype, src_ctype) != 0) ereport(ERROR, (errmsg("new LC_CTYPE is incompatible with LC_CTYPE of the template database (%s)", src_ctype), errhint("Use the same LC_CTYPE as in the template database, or use template0 as template.")));