From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Wed, 4 Dec 2002 20:00:19 +0000 (+0000)
Subject: Repair oversight in recent change of dependency extraction code: when
X-Git-Url: http://git.postgresql.org/gitweb/static/gitweb.js?a=commitdiff_plain;h=6069456f9ea0d78877abbba827a54a589b0f3b8d;p=users%2Fbernd%2Fpostgres.git

Repair oversight in recent change of dependency extraction code: when
recursing to handle a join alias var, the context had better be set to
be appropriate to the join var's query level.  Per report from Hristo Neshev.
---

diff --git a/src/backend/catalog/dependency.c b/src/backend/catalog/dependency.c
index fa3a503755..c9abc26df0 100644
--- a/src/backend/catalog/dependency.c
+++ b/src/backend/catalog/dependency.c
@@ -789,6 +789,11 @@ find_expr_references_walker(Node *node,
 		else if (rte->rtekind == RTE_JOIN)
 		{
 			/* Scan join output column to add references to join inputs */
+			List   *save_rtables;
+
+			/* We must make the context appropriate for join's level */
+			save_rtables = context->rtables;
+			context->rtables = rtables;
 			if (var->varattno <= 0 ||
 				var->varattno > length(rte->joinaliasvars))
 				elog(ERROR, "find_expr_references_walker: bogus varattno %d",
@@ -796,6 +801,7 @@ find_expr_references_walker(Node *node,
 			find_expr_references_walker((Node *) nth(var->varattno - 1,
 													 rte->joinaliasvars),
 										context);
+			context->rtables = save_rtables;
 		}
 		return false;
 	}