From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Fri, 20 Oct 2006 01:10:35 +0000 (+0000)
Subject: Back-patch second version of AIX getaddrinfo fix.
X-Git-Url: http://git.postgresql.org/gitweb/static/gitweb.js?a=commitdiff_plain;h=4c75b8990327c19adbe5a905d2e7d719ea01d415;p=users%2Fbernd%2Fpostgres.git

Back-patch second version of AIX getaddrinfo fix.
---

diff --git a/src/backend/libpq/ip.c b/src/backend/libpq/ip.c
index c75589fc66..30c4e60cd6 100644
--- a/src/backend/libpq/ip.c
+++ b/src/backend/libpq/ip.c
@@ -67,6 +67,8 @@ int
 getaddrinfo_all(const char *hostname, const char *servname,
 				const struct addrinfo * hintp, struct addrinfo ** result)
 {
+	int			rc;
+
 	/* not all versions of getaddrinfo() zero *result on failure */
 	*result = NULL;
 
@@ -75,18 +77,37 @@ getaddrinfo_all(const char *hostname, const char *servname,
 		return getaddrinfo_unix(servname, hintp, result);
 #endif
 
+	/* NULL has special meaning to getaddrinfo(). */
+	rc = getaddrinfo((!hostname || hostname[0] == '\0') ? NULL : hostname,
+					 servname, hintp, result);
+
 #ifdef _AIX
 	/*
-	 * It seems AIX's getaddrinfo doesn't reliably zero sin_port when servname
-	 * is NULL, so force the issue.
+	 * It seems some versions of AIX's getaddrinfo don't reliably zero
+	 * sin_port when servname is NULL, so clean up after it.
 	 */
-	if (servname == NULL)
-		servname = "0";
+	if (servname == NULL && rc == 0)
+	{
+		struct addrinfo *addr;
+
+		for (addr = *result; addr; addr = addr->ai_next)
+		{
+			switch (addr->ai_family)
+			{
+				case AF_INET:
+					((struct sockaddr_in *) addr->ai_addr)->sin_port = htons(0);
+					break;
+#ifdef HAVE_IPV6
+				case AF_INET6:
+					((struct sockaddr_in6 *) addr->ai_addr)->sin6_port = htons(0);
+					break;
+#endif
+			}
+		}
+	}
 #endif
 
-	/* NULL has special meaning to getaddrinfo(). */
-	return getaddrinfo((!hostname || hostname[0] == '\0') ? NULL : hostname,
-					   servname, hintp, result);
+	return rc;
 }