From: Magnus Hagander <magnus@hagander.net>
Date: Tue, 31 Mar 2009 18:58:26 +0000 (+0000)
Subject: Don't crash initdb when we fail to get the current username.
X-Git-Url: http://git.postgresql.org/gitweb/static/gitweb.js?a=commitdiff_plain;h=477a6c165023ea0cf974f8e95ed34566d1589ed0;p=users%2Fbernd%2Fpostgres.git

Don't crash initdb when we fail to get the current username.
Give an error message and exit instead, like we do elsewhere...

Per report from Wez Furlong and Robert Treat.
---

diff --git a/src/bin/initdb/initdb.c b/src/bin/initdb/initdb.c
index 3ce8d22a06..830d3c1627 100644
--- a/src/bin/initdb/initdb.c
+++ b/src/bin/initdb/initdb.c
@@ -642,6 +642,13 @@ get_id(void)
 		exit(1);
 	}
 #endif
+	if (!pw)
+	{
+		fprintf(stderr,
+				_("%s: could not obtain information about current user: %s\n"),
+				 progname, strerror(errno));
+		exit(1);
+	}
 #else							/* the windows code */
 
 	struct passwd_win32
@@ -653,7 +660,12 @@ get_id(void)
 	DWORD		pwname_size = sizeof(pass_win32.pw_name) - 1;
 
 	pw->pw_uid = 1;
-	GetUserName(pw->pw_name, &pwname_size);
+	if (!GetUserName(pw->pw_name, &pwname_size))
+	{
+		fprintf(stderr, _("%s: could not get current user name: %s\n"),
+				progname, strerror(errno));
+		exit(1);
+	}
 #endif
 
 	return xstrdup(pw->pw_name);