From: Álvaro Herrera Date: Sat, 11 Oct 2025 14:39:22 +0000 (+0200) Subject: dbase_redo: Fix Valgrind-reported memory leak X-Git-Tag: REL_18_1~97 X-Git-Url: http://git.postgresql.org/gitweb/static/gitweb.js?a=commitdiff_plain;h=33e7b4a7c7da6db40c57a224a7cf9b2ebac28861;p=postgresql.git dbase_redo: Fix Valgrind-reported memory leak Introduced by my (Álvaro's) commit 9e4f914b5eba, which was itself backpatched to pg10, though only pg15 and up contain the problem because of commit 9c08aea6a309. This isn't a particularly significant leak, but given the fix is trivial, we might as well backpatch to all branches where it applies, so do that. Author: Nathan Bossart Reported-by: Andres Freund Discussion: https://postgr.es/m/x4odfdlrwvsjawscnqsqjpofvauxslw7b4oyvxgt5owoyf4ysn@heafjusodrz7 --- diff --git a/src/backend/commands/dbcommands.c b/src/backend/commands/dbcommands.c index ef99375d72b..5a46002c60b 100644 --- a/src/backend/commands/dbcommands.c +++ b/src/backend/commands/dbcommands.c @@ -3398,6 +3398,7 @@ dbase_redo(XLogReaderState *record) parent_path = pstrdup(dbpath); get_parent_directory(parent_path); recovery_create_dbdir(parent_path, true); + pfree(parent_path); /* Create the database directory with the version file. */ CreateDirAndVersionFile(dbpath, xlrec->db_id, xlrec->tablespace_id,