From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Tue, 3 Feb 2009 00:59:26 +0000 (+0000)
Subject: Add a failure check for syslogger's use of _beginthreadex(), and remove
X-Git-Url: http://git.postgresql.org/gitweb/static/gitweb.js?a=commitdiff_plain;h=2327a395624f9a8a6592447251f5a90c26918278;p=users%2Fsimon%2Fpostgres.git

Add a failure check for syslogger's use of _beginthreadex(), and remove
unnecessary thread address output parameter, to make this code look more
like that in pg_restore.
---

diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c
index 461c1ffbe8..988b0e04ff 100644
--- a/src/backend/postmaster/syslogger.c
+++ b/src/backend/postmaster/syslogger.c
@@ -267,11 +267,9 @@ SysLoggerMain(int argc, char *argv[])
 	/* Fire up separate data transfer thread */
 	InitializeCriticalSection(&sysfileSection);
 
-	{
-		unsigned int tid;
-
-		threadHandle = (HANDLE) _beginthreadex(0, 0, pipeThread, 0, 0, &tid);
-	}
+	threadHandle = (HANDLE) _beginthreadex(NULL, 0, pipeThread, NULL, 0, NULL);
+	if (threadHandle == 0)
+		elog(FATAL, "could not create syslogger data transfer thread: %m");
 #endif   /* WIN32 */
 
 	/* remember active logfile parameters */