From: Tom Lane Date: Tue, 15 Jan 2008 22:18:20 +0000 (+0000) Subject: Be less wishy-washy in the documentation and comments about whether a X-Git-Url: http://git.postgresql.org/gitweb/static/gitweb.js?a=commitdiff_plain;h=1a9d6f189ea9c065edc6256387ecee512c60dc60;p=users%2Fbernd%2Fpostgres.git Be less wishy-washy in the documentation and comments about whether a ParameterStatus message can be sent during COPY OUT: it's definitely possible, since COPY from a SELECT subquery can trigger any user-defined function. --- diff --git a/doc/src/sgml/protocol.sgml b/doc/src/sgml/protocol.sgml index 13ab98a4fe..c26cccc45f 100644 --- a/doc/src/sgml/protocol.sgml +++ b/doc/src/sgml/protocol.sgml @@ -1044,10 +1044,10 @@ - It is possible for NoticeResponse messages to be interspersed between - CopyData messages; frontends must handle this case, and should be - prepared for other asynchronous message types as well (see ). Otherwise, any message type other than + It is possible for NoticeResponse and ParameterStatus messages to be + interspersed between CopyData messages; frontends must handle these cases, + and should be prepared for other asynchronous message types as well (see + ). Otherwise, any message type other than CopyData or CopyDone may be treated as terminating copy-out mode. diff --git a/src/interfaces/libpq/fe-protocol3.c b/src/interfaces/libpq/fe-protocol3.c index 5e352480cd..f473588526 100644 --- a/src/interfaces/libpq/fe-protocol3.c +++ b/src/interfaces/libpq/fe-protocol3.c @@ -1310,9 +1310,8 @@ getCopyDataMessage(PGconn *conn) /* * If it's a legitimate async message type, process it. (NOTIFY * messages are not currently possible here, but we handle them for - * completeness. NOTICE is definitely possible, and ParameterStatus - * could probably be made to happen.) Otherwise, if it's anything - * except Copy Data, report end-of-copy. + * completeness.) Otherwise, if it's anything except Copy Data, + * report end-of-copy. */ switch (id) {