From: Kris Jurka <books@ejurka.com>
Date: Tue, 10 Feb 2004 01:58:48 +0000 (+0000)
Subject: Don't try to turn the random bytes from a md5 salt into a String
X-Git-Url: http://git.postgresql.org/gitweb/static/gitweb.js?a=commitdiff_plain;h=1615ffe4794aa87187f177f3d1ca75e8c12ef78c;p=users%2Fbernd%2Fpostgres.git

Don't try to turn the random bytes from a md5 salt into a String
because it may not be a valid String depending on the encoding.

Per report from Nadeem Bitar.
---

diff --git a/src/interfaces/jdbc/org/postgresql/jdbc1/AbstractJdbc1Connection.java b/src/interfaces/jdbc/org/postgresql/jdbc1/AbstractJdbc1Connection.java
index 33cab33cef..ddee229d6e 100644
--- a/src/interfaces/jdbc/org/postgresql/jdbc1/AbstractJdbc1Connection.java
+++ b/src/interfaces/jdbc/org/postgresql/jdbc1/AbstractJdbc1Connection.java
@@ -349,9 +349,13 @@ public abstract class AbstractJdbc1Connection implements BaseConnection
 							md5Salt[1] = (byte)pgStream.ReceiveChar();
 							md5Salt[2] = (byte)pgStream.ReceiveChar();
 							md5Salt[3] = (byte)pgStream.ReceiveChar();
-							salt = new String(md5Salt, 0, 4);
-							if (Driver.logDebug)
-								Driver.debug("MD5 salt=" + salt);
+							if (Driver.logDebug) {
+								String md5SaltString = "";
+								for (int i=0; i<md5Salt.length; i++) {
+									md5SaltString += " " + md5Salt[i];
+								}
+								Driver.debug("MD5 salt=" + md5SaltString);
+							}
 						}
 
 						// now send the auth packet
@@ -631,9 +635,13 @@ public abstract class AbstractJdbc1Connection implements BaseConnection
 							md5Salt[1] = (byte)pgStream.ReceiveChar();
 							md5Salt[2] = (byte)pgStream.ReceiveChar();
 							md5Salt[3] = (byte)pgStream.ReceiveChar();
-							salt = new String(md5Salt, 0, 4);
-							if (Driver.logDebug)
-								Driver.debug("MD5 salt=" + salt);
+							if (Driver.logDebug) {
+								String md5SaltString = "";
+								for (int i=0; i<md5Salt.length; i++) {
+									md5SaltString += " " + md5Salt[i];
+								}
+								Driver.debug("MD5 salt=" + md5SaltString);
+							}
 						}
 
 						// now send the auth packet