Let many GUC parameters be user-settable, compatible with PG.

They were made SUSET to support multi-tenant environment, but no longer
applicable to the current use case of XL.

diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c
index dd5c0d6d04eaee5cc0ca22d189583607be246788..f2559100af4ace3c1c9bc64a3f56c046372c73bb 100644 (file)
--- a/src/backend/utils/misc/guc.c
+++ b/src/backend/utils/misc/guc.c
@@ -1670,11 +1670,7 @@ static struct config_bool ConfigureNamesBool[] =
        },
 
        {
-#ifdef XCP
-               {"synchronize_seqscans", PGC_SUSET, COMPAT_OPTIONS_PREVIOUS,
-#else
                {"synchronize_seqscans", PGC_USERSET, COMPAT_OPTIONS_PREVIOUS,
-#endif
                        gettext_noop("Enable synchronized sequential scans."),
                        NULL
                },
@@ -2001,11 +1997,7 @@ static struct config_int ConfigureNamesInt[] =
        },
 
        {
-#ifdef XCP
-               {"temp_buffers", PGC_SUSET, RESOURCES_MEM,
-#else
                {"temp_buffers", PGC_USERSET, RESOURCES_MEM,
-#endif
                        gettext_noop("Sets the maximum number of temporary buffers used by each session."),
                        NULL,
                        GUC_UNIT_BLOCKS
@@ -2055,11 +2047,7 @@ static struct config_int ConfigureNamesInt[] =
        },
 
        {
-#ifdef XCP
-               {"work_mem", PGC_SUSET, RESOURCES_MEM,
-#else
                {"work_mem", PGC_USERSET, RESOURCES_MEM,
-#endif
                        gettext_noop("Sets the maximum memory to be used for query workspaces."),
                        gettext_noop("This much memory can be used by each internal "
                                                 "sort operation and hash table before switching to "
@@ -2072,11 +2060,7 @@ static struct config_int ConfigureNamesInt[] =
        },
 
        {
-#ifdef XCP
-               {"maintenance_work_mem", PGC_SUSET, RESOURCES_MEM,
-#else
                {"maintenance_work_mem", PGC_USERSET, RESOURCES_MEM,
-#endif
                        gettext_noop("Sets the maximum memory to be used for maintenance operations."),
                        gettext_noop("This includes operations such as VACUUM and CREATE INDEX."),
                        GUC_UNIT_KB
@@ -2483,11 +2467,7 @@ static struct config_int ConfigureNamesInt[] =
        },
 
        {
-#ifdef XCP
-               {"commit_siblings", PGC_SUSET, WAL_SETTINGS,
-#else
                {"commit_siblings", PGC_USERSET, WAL_SETTINGS,
-#endif
                        gettext_noop("Sets the minimum concurrent open transactions before performing "
                                                 "commit_delay."),
                        NULL