Add CHECK_FOR_INTERRUPTS while restoring changes during decoding.
authorAmit Kapila <[email protected]>
Fri, 21 Oct 2022 06:40:11 +0000 (12:10 +0530)
committerAmit Kapila <[email protected]>
Fri, 21 Oct 2022 06:40:11 +0000 (12:10 +0530)
Previously in commit 42681dffaf, we added CFI during decoding changes but
missed another similar case that can happen while restoring changes
spilled to disk back into memory in a loop.

Reported-by: Robert Haas
Author: Amit Kapila
Backpatch-through: 10
Discussion: https://postgr.es/m/CA+TgmoaLObg0QbstbC8ykDwOdD1bDkr4AbPpB=0DPgA2JW0mFg@mail.gmail.com

src/backend/replication/logical/reorderbuffer.c

index 7f0ecec3175a89d5139979dca9f82353adfbaecb..76e6cf5134fcbc564a5711eee836a3f8ea3a630c 100644 (file)
@@ -2595,6 +2595,8 @@ ReorderBufferRestoreChanges(ReorderBuffer *rb, ReorderBufferTXN *txn,
        int         readBytes;
        ReorderBufferDiskChange *ondisk;
 
+       CHECK_FOR_INTERRUPTS();
+
        if (*fd == -1)
        {
            char        path[MAXPGPATH];