Explain's code for showing quals of SubqueryScan nodes has been broken

all along; not noticed till now.  It's a scan not an upper qual ...

diff --git a/src/backend/commands/explain.c b/src/backend/commands/explain.c
index eceb81daef9bd2ec26e8310e8cf8ea71313b0701..6ddf2e28b8a162bbb263af0ea866184a7677f4d8 100644 (file)
--- a/src/backend/commands/explain.c
+++ b/src/backend/commands/explain.c
@@ -432,6 +432,7 @@ explain_outNode(StringInfo str, Plan *plan, Plan *outer_plan,
                        break;
                case T_SeqScan:
                case T_TidScan:
+               case T_SubqueryScan:
                case T_FunctionScan:
                        show_scan_qual(plan->qual, false,
                                                   "Filter",
@@ -485,13 +486,6 @@ explain_outNode(StringInfo str, Plan *plan, Plan *outer_plan,
                                                        "inner", INNER, innerPlan(plan),
                                                        str, indent, es);
                        break;
-               case T_SubqueryScan:
-                       show_upper_qual(plan->qual,
-                                                       "Filter",
-                                                 "subplan", 1, ((SubqueryScan *) plan)->subplan,
-                                                       "", 0, NULL,
-                                                       str, indent, es);
-                       break;
                case T_Agg:
                case T_Group:
                        show_upper_qual(plan->qual,