Iterate over the whole simple_rel_array in WITH RECURSIVE check

The loop over in subquery_planner() looked about like this:

    for (i = 1; i < root->simple_rel_array_size - 1; i++)

which fails to check the last element in the array, due to a trivial
off-by-one error. Instead, the loop should be:

    for (i = 1; i < root->simple_rel_array_size; i++)

diff --git a/src/backend/optimizer/plan/planner.c b/src/backend/optimizer/plan/planner.c
index 6bd699310b3b2c5a544f6819adc3fca9c4608a70..7cc28acd24e6427c07202ff500624cb77ac53942 100644 (file)
--- a/src/backend/optimizer/plan/planner.c
+++ b/src/backend/optimizer/plan/planner.c
@@ -866,7 +866,7 @@ subquery_planner(PlannerGlobal *glob, Query *parse,
                recursiveOk = true;
 
                /* seems to start at 1... */
-               for (idx = 1; idx < root->simple_rel_array_size - 1 && recursiveOk; idx++)
+               for (idx = 1; idx < root->simple_rel_array_size && recursiveOk; idx++)
                {
                        RangeTblEntry *rte;