Fix outfuncs.c to dump A_Const nodes representing NULLs correctly. This has

been broken since forever, but was not noticed because people seldom look
at raw parse trees.  AFAIK, no impact on users except that debug_print_parse
might fail; but patch it all the way back anyway.  Per report from Jeff Ross.

diff --git a/src/backend/nodes/outfuncs.c b/src/backend/nodes/outfuncs.c
index 5ff9b93eae6f8822b843ad85e54fa775c7d2642c..6534ca35dfe2663692e3a27234f5addc3fd55b64 100644 (file)
--- a/src/backend/nodes/outfuncs.c
+++ b/src/backend/nodes/outfuncs.c
@@ -1632,6 +1632,10 @@ _outValue(StringInfo str, Value *value)
                        /* internal representation already has leading 'b' */
                        appendStringInfoString(str, value->val.str);
                        break;
+               case T_Null:
+                       /* this is seen only within A_Const, not in transformed trees */
+                       appendStringInfoString(str, "NULL");
+                       break;
                default:
                        elog(ERROR, "unrecognized node type: %d", (int) value->type);
                        break;
@@ -1659,6 +1663,7 @@ _outAConst(StringInfo str, A_Const *node)
 {
        WRITE_NODE_TYPE("A_CONST");
 
+       appendStringInfo(str, " :val ");
        _outValue(str, &(node->val));
        WRITE_NODE_FIELD(typename);
 }