Fix bug in GIN WAL redo cleanup function: don't free fake relcache entry

while it's still being used.

Backpatch to 8.4, where the fake relcache method was introduced.

diff --git a/src/backend/access/gin/ginxlog.c b/src/backend/access/gin/ginxlog.c
index 8126be81ee725cdd8e16eb2136291a8992b68fa5..3633bdc0f59e0b932dfa09020318afedb599c5d4 100644 (file)
--- a/src/backend/access/gin/ginxlog.c
+++ b/src/backend/access/gin/ginxlog.c
@@ -777,8 +777,6 @@ ginContinueSplit(ginIncompleteSplit *split)
                                       GinPageGetOpaque(page)->maxoff))->key;
    }
 
-   FreeFakeRelcacheEntry(reln);
-
    btree.rightblkno = split->rightBlkno;
 
    stack.blkno = split->leftBlkno;
@@ -789,6 +787,8 @@ ginContinueSplit(ginIncompleteSplit *split)
    findParents(&btree, &stack, split->rootBlkno);
    ginInsertValue(&btree, stack.parent);
 
+   FreeFakeRelcacheEntry(reln);
+
    UnlockReleaseBuffer(buffer);
 }