Got tired of explaining why this Assert is not wrong.

diff --git a/src/backend/utils/hash/dynahash.c b/src/backend/utils/hash/dynahash.c
index 46145787894c61883b20a85048365b837722ff8e..18eba0662ee3de1b5477dc78cfa613c001fffa86 100644 (file)
--- a/src/backend/utils/hash/dynahash.c
+++ b/src/backend/utils/hash/dynahash.c
@@ -540,7 +540,8 @@ hash_search(HTAB *hashp,
                /*
                 * Try to catch subsequent errors
                 */
-               Assert(currBucket && !(saveState.currBucket = NULL));
+               Assert(currBucket);
+               saveState.currBucket = NULL;
        }
        else
        {