Fix for endless restart loop on FAILOVER (bug 318).

If the backup node is not the most advanced, function
failedNode() will trigger a slon restart even if it
did not make any changes to the configuration because
of a missing WHERE clause.

diff --git a/src/backend/slony1_funcs.sql b/src/backend/slony1_funcs.sql
index d6a19a97ab8527610cd4d444b7e1e42747214f8b..589786ee83dd15d7c5f5ea64afc00af81f3a77cf 100644 (file)
--- a/src/backend/slony1_funcs.sql
+++ b/src/backend/slony1_funcs.sql
@@ -1234,7 +1234,8 @@ begin
        -- the failed node even if it *does* become accessible
 
        update @[email protected]_path set pa_conninfo='<event pending>' WHERE
-                         pa_server=p_failed_node;
+                         pa_server=p_failed_node
+                         and pa_conninfo<>'<event pending>';
 
        if found then
           v_restart_required:=true;