Fix bug corrupting query in gist consistent function.

Thank to Mario Weilguni <[email protected]> to discover a bug.

diff --git a/contrib/ltree/_ltree_gist.c b/contrib/ltree/_ltree_gist.c
index 84f4da9d6201706fde40b5b306cd3c2600e1a3be..9069d0150a5fdd28a1013a4d36849dfdb315bd8d 100644 (file)
--- a/contrib/ltree/_ltree_gist.c
+++ b/contrib/ltree/_ltree_gist.c
@@ -569,5 +569,6 @@ _ltree_consistent(PG_FUNCTION_ARGS)
            /* internal error */
            elog(ERROR, "unrecognized StrategyNumber: %d", strategy);
    }
+   PG_FREE_IF_COPY(query,1);
    PG_RETURN_BOOL(res);
 }

diff --git a/contrib/ltree/ltree.h b/contrib/ltree/ltree.h
index c55c757016ab1fc40b96931d74bd87d80fec1e1a..2c9be494d16453a3eb724f1e5476ffd0afb186a4 100644 (file)
--- a/contrib/ltree/ltree.h
+++ b/contrib/ltree/ltree.h
@@ -161,8 +161,11 @@ bool compare_subnode(ltree_level * t, char *q, int len,
 ltree     *lca_inner(ltree ** a, int len);
 
 #define PG_GETARG_LTREE(x) ((ltree*)DatumGetPointer(PG_DETOAST_DATUM(PG_GETARG_DATUM(x))))
+#define PG_GETARG_LTREE_COPY(x)    ((ltree*)DatumGetPointer(PG_DETOAST_DATUM_COPY(PG_GETARG_DATUM(x))))
 #define PG_GETARG_LQUERY(x) ((lquery*)DatumGetPointer(PG_DETOAST_DATUM(PG_GETARG_DATUM(x))))
+#define PG_GETARG_LQUERY_COPY(x) ((lquery*)DatumGetPointer(PG_DETOAST_DATUM_COPY(PG_GETARG_DATUM(x))))
 #define PG_GETARG_LTXTQUERY(x) ((ltxtquery*)DatumGetPointer(PG_DETOAST_DATUM(PG_GETARG_DATUM(x))))
+#define PG_GETARG_LTXTQUERY_COPY(x) ((ltxtquery*)DatumGetPointer(PG_DETOAST_DATUM_COPY(PG_GETARG_DATUM(x))))
 
 /* GiST support for ltree */
 

diff --git a/contrib/ltree/ltree_gist.c b/contrib/ltree/ltree_gist.c
index ec81ce1c1835af66f544b3305bfbf1d5246ae7c1..5a6aa94e91cfff558e847bb781a0ee4a05487964 100644 (file)
--- a/contrib/ltree/ltree_gist.c
+++ b/contrib/ltree/ltree_gist.c
@@ -626,7 +626,7 @@ Datum
 ltree_consistent(PG_FUNCTION_ARGS)
 {
    GISTENTRY  *entry = (GISTENTRY *) PG_GETARG_POINTER(0);
-   char       *query = (char *) DatumGetPointer(PG_DETOAST_DATUM(PG_GETARG_DATUM(1)));
+   void       *query = NULL;
    ltree_gist *key = (ltree_gist *) DatumGetPointer(entry->key);
    StrategyNumber strategy = (StrategyNumber) PG_GETARG_UINT16(2);
    bool        res = false;
@@ -638,15 +638,18 @@ ltree_consistent(PG_FUNCTION_ARGS)
    switch (strategy)
    {
        case BTLessStrategyNumber:
+           query = PG_GETARG_LTREE(1);
            res = (GIST_LEAF(entry)) ?
                (ltree_compare((ltree *) query, LTG_NODE(key)) > 0)
                :
                (ltree_compare((ltree *) query, LTG_GETLNODE(key)) >= 0);
            break;
        case BTLessEqualStrategyNumber:
+           query = PG_GETARG_LTREE(1);
            res = (ltree_compare((ltree *) query, LTG_GETLNODE(key)) >= 0);
            break;
        case BTEqualStrategyNumber:
+           query = PG_GETARG_LTREE(1);
            if (GIST_LEAF(entry))
                res = (ltree_compare((ltree *) query, LTG_NODE(key)) == 0);
            else
@@ -657,21 +660,25 @@ ltree_consistent(PG_FUNCTION_ARGS)
                    );
            break;
        case BTGreaterEqualStrategyNumber:
+           query = PG_GETARG_LTREE(1);
            res = (ltree_compare((ltree *) query, LTG_GETRNODE(key)) <= 0);
            break;
        case BTGreaterStrategyNumber:
+           query = PG_GETARG_LTREE(1);
            res = (GIST_LEAF(entry)) ?
                (ltree_compare((ltree *) query, LTG_GETRNODE(key)) < 0)
                :
                (ltree_compare((ltree *) query, LTG_GETRNODE(key)) <= 0);
            break;
        case 10:
+           query = PG_GETARG_LTREE_COPY(1);
            res = (GIST_LEAF(entry)) ?
                inner_isparent((ltree *) query, LTG_NODE(key))
                :
                gist_isparent(key, (ltree *) query);
            break;
        case 11:
+           query = PG_GETARG_LTREE_COPY(1);
            res = (GIST_LEAF(entry)) ?
                inner_isparent(LTG_NODE(key), (ltree *) query)
                :
@@ -679,6 +686,7 @@ ltree_consistent(PG_FUNCTION_ARGS)
            break;
        case 12:
        case 13:
+           query = PG_GETARG_LQUERY(1);
            if (GIST_LEAF(entry))
                res = DatumGetBool(DirectFunctionCall2(ltq_regex,
                                          PointerGetDatum(LTG_NODE(key)),
@@ -689,6 +697,7 @@ ltree_consistent(PG_FUNCTION_ARGS)
            break;
        case 14:
        case 15:
+           query = PG_GETARG_LQUERY(1);
            if (GIST_LEAF(entry))
                res = DatumGetBool(DirectFunctionCall2(ltxtq_exec,
                                          PointerGetDatum(LTG_NODE(key)),
@@ -699,6 +708,7 @@ ltree_consistent(PG_FUNCTION_ARGS)
            break;
        case 16:
        case 17:
+           query = DatumGetPointer(PG_DETOAST_DATUM(PG_GETARG_DATUM(1)));
            if (GIST_LEAF(entry))
                res = DatumGetBool(DirectFunctionCall2(lt_q_regex,
                                          PointerGetDatum(LTG_NODE(key)),
@@ -711,5 +721,7 @@ ltree_consistent(PG_FUNCTION_ARGS)
            /* internal error */
            elog(ERROR, "unrecognized StrategyNumber: %d", strategy);
    }
+
+   PG_FREE_IF_COPY(query,1);
    PG_RETURN_BOOL(res);
 }