Pass sensible value to memset() when randomizing reorderbuffer's tuple slab.

This is entirely harmless, but still wrong. Noticed by coverity.

Andres Freund

diff --git a/src/backend/replication/logical/reorderbuffer.c b/src/backend/replication/logical/reorderbuffer.c
index e0e9e5c5b89f2441b7101fde93b1763691b92c7e..a2b2adb173260aeddb8bb6ad4f5dc4b2a3582715 100644 (file)
--- a/src/backend/replication/logical/reorderbuffer.c
+++ b/src/backend/replication/logical/reorderbuffer.c
@@ -456,7 +456,7 @@ ReorderBufferGetTupleBuf(ReorderBuffer *rb)
                tuple = slist_container(ReorderBufferTupleBuf, node,
                                                                slist_pop_head_node(&rb->cached_tuplebufs));
 #ifdef USE_ASSERT_CHECKING
-               memset(tuple, 0xdeadbeef, sizeof(ReorderBufferTupleBuf));
+               memset(tuple, 0xa9, sizeof(ReorderBufferTupleBuf));
 #endif
        }
        else