Fix overflow in extract(epoch from interval) for intervals exceeding 68 years.

Seems to have been introduced in 8.1 by careless SECS_PER_DAY
search-and-replace.

diff --git a/src/backend/utils/adt/timestamp.c b/src/backend/utils/adt/timestamp.c
index 52922c90344256611a769e399903f88f94bafa29..1ec8a99e86584a34854ac3775e301b78d412abc9 100644 (file)
--- a/src/backend/utils/adt/timestamp.c
+++ b/src/backend/utils/adt/timestamp.c
@@ -4190,9 +4190,9 @@ interval_part(PG_FUNCTION_ARGS)
 #else
                result = interval->time;
 #endif
-               result += (DAYS_PER_YEAR * SECS_PER_DAY) * (interval->month / MONTHS_PER_YEAR);
+               result += ((double) DAYS_PER_YEAR * SECS_PER_DAY) * (interval->month / MONTHS_PER_YEAR);
                result += ((double) DAYS_PER_MONTH * SECS_PER_DAY) * (interval->month % MONTHS_PER_YEAR);
-               result += interval->day * SECS_PER_DAY;
+               result += ((double) SECS_PER_DAY) * interval->day;
        }
        else
        {