More Perl::Critic tweaks

diff --git a/.perlcriticrc b/.perlcriticrc
index 2645ed9f43caa3e2317b9e634cd48e6fee7e907b..0237e9127999b173befcb292d20a1c300bd90ba8 100644 (file)
--- a/.perlcriticrc
+++ b/.perlcriticrc
@@ -38,6 +38,7 @@ stop_words = Mullane Nagios Slony nols salesrep psql dbname postgres USERNAME us
 [-Miscellanea::RequireRcsKeywords]
 [-Modules::ProhibitExcessMainComplexity]
 [-Modules::RequireExplicitInclusion]
+[-Modules::RequireFilenameMatchesPackage]
 [-NamingConventions::Capitalization]
 [-NamingConventions::ProhibitAmbiguousNames]
 [-NamingConventions::ProhibitMixedCaseVars]

diff --git a/Makefile.PL b/Makefile.PL
index b9f79fa6771ac9b8cc28f96a03b2feea76e2708e..7ef5a6f00b83426cf9c4cef5dfddad7953b8de88 100644 (file)
--- a/Makefile.PL
+++ b/Makefile.PL
@@ -57,7 +57,7 @@ my %opts =
 );
 
 {
-       package MY; ## no critic
+       package MY;
        sub clean { ## no critic (RequireArgUnpacking)
                my $string = shift->SUPER::clean(@_);
                $string =~ s{\t}{\tperl t/99_cleanup\.t\n\t};

diff --git a/check_postgres.pl b/check_postgres.pl
index a3c60b3e171414f84c33a95e6a2e24cc61b00c8d..3725c4374904cbb4f3131765f967d014667e1ca7 100755 (executable)
--- a/check_postgres.pl
+++ b/check_postgres.pl
@@ -4262,10 +4262,10 @@ sub check_same_schema {
                                        push @{$filter{"no${type}_regex"}} => $1;
                                }
                        }
-                       if ($phrase =~ /^noposition$/io) {
+                       if ($phrase =~ /^noposition$/io) { ## no critic (ProhibitFixedStringMatches)
                                $filter{noposition} = 1;
                        }
-                       if ($phrase =~ /^nofuncbody$/io) {
+                       if ($phrase =~ /^nofuncbody$/io) { ## no critic (ProhibitFixedStringMatches)
                                $filter{nofuncbody} = 1;
                        }
                }