Remove some pre-WAL relics:

  SharedBufferChanged
  BufferRelidLastDirtied
  BufferTagLastDirtied
  BufferDirtiedByMe

Manfred Koizar

diff --git a/src/backend/access/transam/xact.c b/src/backend/access/transam/xact.c
index ae3e2f8f955f039415799d0ccbda71a311bedc15..1e0b5eda28cf92549e77f6590102177b710ca893 100644 (file)
--- a/src/backend/access/transam/xact.c
+++ b/src/backend/access/transam/xact.c
@@ -182,8 +182,6 @@
 #include "pgstat.h"
 
 
-extern bool SharedBufferChanged;
-
 static void AbortTransaction(void);
 static void AtAbort_Cache(void);
 static void AtAbort_Locks(void);
@@ -991,8 +989,6 @@ CommitTransaction(void)
        AtCommit_Memory();
        AtEOXact_Files();
 
-       SharedBufferChanged = false;    /* safest place to do it */
-
        /* Count transaction commit in statistics collector */
        pgstat_count_xact_commit();
 
@@ -1094,8 +1090,6 @@ AbortTransaction(void)
        AtEOXact_Files();
        AtAbort_Locks();
 
-       SharedBufferChanged = false;    /* safest place to do it */
-
        /* Count transaction abort in statistics collector */
        pgstat_count_xact_rollback();
 

diff --git a/src/backend/storage/buffer/buf_init.c b/src/backend/storage/buffer/buf_init.c
index 42e6daba18fc95f7dd7867bdeb274870ee65372b..29f92e9699e8dc114b59bfa949bd13def5ea1f31 100644 (file)
--- a/src/backend/storage/buffer/buf_init.c
+++ b/src/backend/storage/buffer/buf_init.c
@@ -60,9 +60,6 @@ Block    *BufferBlockPointers;
 
 long      *PrivateRefCount;    /* also used in freelist.c */
 bits8     *BufferLocks;                /* flag bits showing locks I have set */
-BufferTag  *BufferTagLastDirtied;              /* tag buffer had when last
-                                                                                * dirtied by me */
-bool      *BufferDirtiedByMe;  /* T if buf has been dirtied in cur xact */
 
 
 /*
@@ -235,9 +232,6 @@ InitBufferPoolAccess(void)
        BufferBlockPointers = (Block *) calloc(NBuffers, sizeof(Block));
        PrivateRefCount = (long *) calloc(NBuffers, sizeof(long));
        BufferLocks = (bits8 *) calloc(NBuffers, sizeof(bits8));
-       BufferTagLastDirtied = (BufferTag *) calloc(NBuffers, sizeof(BufferTag));
-       BufferDirtiedByMe = (bool *) calloc(NBuffers, sizeof(bool));
-
        /*
         * Convert shmem offsets into addresses as seen by this process. This
         * is just to speed up the BufferGetBlock() macro.

diff --git a/src/backend/storage/buffer/bufmgr.c b/src/backend/storage/buffer/bufmgr.c
index fc52ff31babb5a79092de3edda45c211d074cc59..5ee5873e8b21103bf223b0c742c4637e4d104863 100644 (file)
--- a/src/backend/storage/buffer/bufmgr.c
+++ b/src/backend/storage/buffer/bufmgr.c
@@ -67,15 +67,6 @@ extern long int LocalBufferHitCount;
 extern long int BufferFlushCount;
 extern long int LocalBufferFlushCount;
 
-/*
- * It's used to avoid disk writes for read-only transactions
- * (i.e. when no one shared buffer was changed by transaction).
- * We set it to true in WriteBuffer/WriteNoReleaseBuffer when
- * marking shared buffer as dirty. We set it to false in xact.c
- * after transaction is committed/aborted.
- */
-bool           SharedBufferChanged = false;
-
 static void WaitIO(BufferDesc *buf);
 static void StartBufferIO(BufferDesc *buf, bool forInput);
 static void TerminateBufferIO(BufferDesc *buf);
@@ -593,8 +584,6 @@ WriteBuffer(Buffer buffer)
 
        bufHdr = &BufferDescriptors[buffer - 1];
 
-       SharedBufferChanged = true;
-
        LWLockAcquire(BufMgrLock, LW_EXCLUSIVE);
        Assert(bufHdr->refcount > 0);
 
@@ -623,8 +612,6 @@ WriteNoReleaseBuffer(Buffer buffer)
 
        bufHdr = &BufferDescriptors[buffer - 1];
 
-       SharedBufferChanged = true;
-
        LWLockAcquire(BufMgrLock, LW_EXCLUSIVE);
        Assert(bufHdr->refcount > 0);
 
@@ -1901,12 +1888,9 @@ _bm_die(Oid dbId, Oid relId, int blkNo, int bufNo,
  *
  *     Mark a buffer dirty when we have updated tuple commit-status bits in it.
  *
- * This is similar to WriteNoReleaseBuffer, except that we do not set
- * SharedBufferChanged or BufferDirtiedByMe, because we have not made a
+ * This is similar to WriteNoReleaseBuffer, except that we have not made a
  * critical change that has to be flushed to disk before xact commit --- the
- * status-bit update could be redone by someone else just as easily.  The
- * buffer will be marked dirty, but it will not be written to disk until
- * there is another reason to write it.
+ * status-bit update could be redone by someone else just as easily.
  *
  * This routine might get called many times on the same page, if we are making
  * the first scan after commit of an xact that added/deleted many tuples.

diff --git a/src/include/storage/buf_internals.h b/src/include/storage/buf_internals.h
index 09e7dbb826a8fd04ae10d3727b82c7cc4d7beaa5..f09754b9978189719fafb9577c6c20fdce32fe05 100644 (file)
--- a/src/include/storage/buf_internals.h
+++ b/src/include/storage/buf_internals.h
@@ -170,9 +170,6 @@ extern bool BufTableInsert(BufferDesc *buf);
 /* bufmgr.c */
 extern BufferDesc *BufferDescriptors;
 extern bits8 *BufferLocks;
-extern BufferTag *BufferTagLastDirtied;
-extern LockRelId *BufferRelidLastDirtied;
-extern bool *BufferDirtiedByMe;
 
 /* localbuf.c */
 extern BufferDesc *LocalBufferDescriptors;