Fix low-probability memory leak in regex execution.
authorTom Lane <[email protected]>
Fri, 18 Sep 2015 17:55:17 +0000 (13:55 -0400)
committerTom Lane <[email protected]>
Fri, 18 Sep 2015 17:55:17 +0000 (13:55 -0400)
commitdc4e8c10169e094f4241efa586459a812bdfd393
tree7e51d683031e2ee17c15783e3340eb49676ae199
parente61fb6d542979bba84b9e8afa73015a142c42541
Fix low-probability memory leak in regex execution.

After an internal failure in shortest() or longest() while pinning down the
exact location of a match, find() forgot to free the DFA structure before
returning.  This is pretty unlikely to occur, since we just successfully
ran the "search" variant of the DFA; but it could happen, and it would
result in a session-lifespan memory leak since this code uses malloc()
directly.  Problem seems to have been aboriginal in Spencer's library,
so back-patch all the way.

In passing, correct a thinko in a comment I added awhile back about the
meaning of the "ntree" field.

I happened across these issues while comparing our code to Tcl's version
of the library.
src/backend/regex/regcomp.c
src/backend/regex/regexec.c
src/include/regex/regguts.h