Fix regression test parallel-make hazard.
authorTom Lane <[email protected]>
Sat, 13 Aug 2016 00:51:59 +0000 (20:51 -0400)
committerTom Lane <[email protected]>
Sat, 13 Aug 2016 00:51:59 +0000 (20:51 -0400)
commitd90463bde1f640f00b77a4a82923ce92fd737901
tree8aef5bc0d09931b6f9f40564d364a998a9c9c2ad
parent16cc6d23b8d012edb92b3b4b5fccf5200127887c
Fix regression test parallel-make hazard.

Back-patch 9.4-era commit 384f933046dc9e9a2b416f5f7b3be30b93587c63 into
the previous branches.  Although that was only advertised as repairing a
problem with missed header-file dependencies, it turns out to also be
important for parallel make safety.  The previous coding allowed two
independent make jobs to get launched concurrently in contrib/spi.
Normally this would be OK, because they are building independent targets;
but if --enable-depend is in use, it's unsafe, because one make run might
try to read a .deps file that the other one is in process of rewriting.
This is evidently the cause of buildfarm member francolin's recent failure
in the 9.2 branch.  I believe this patch will result in only one subsidiary
make run, making it safe(r).

Report: http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=francolin&dt=2016-08-12%2017%3A12%3A52
src/test/regress/GNUmakefile